linux-kernel - Re: [PATCH] coccinelle: api: fix kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68701ff1-bff5-c3f9-a970-fb7670ac112e@kernel.dk>
Date:   Thu, 27 Aug 2020 16:24:26 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Julia Lawall <julia.lawall@...ia.fr>,
        Keith Busch <kbusch@...nel.org>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Denis Efremov <efremov@...ux.com>, kbuild-all@...ts.01.org
Subject: Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

On 8/27/20 2:13 PM, Julia Lawall wrote:
> Use kobj_to_dev() instead of container_of()
> 
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci

Seem to see more of these, these days. I don't really like them, why not
just use container_of? The private bla_to_foo() helpers should go away,
they are actively hurting readability of the code imho.

-- 
Jens Axboe