linux-kernel - Re: [PATCH v2 1/2] drm/amdkfd: Move the ignore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8caa6963-a296-8fac-4477-f8c3974efd14@huawei.com>
Date:   Thu, 27 Aug 2020 14:21:36 +0800
From:   Hanjun Guo <guohanjun@...wei.com>
To:     Felix Kuehling <felix.kuehling@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] drm/amdkfd: Move the ignore_crat check before the
 CRAT table get

On 2020/8/27 12:28, Felix Kuehling wrote:
> 
> Am 2020-08-26 um 4:29 a.m. schrieb Hanjun Guo:
>> If the ignore_crat is set to non-zero value, it's no point getting
>> the CRAT table, so just move the ignore_crat check before we get the
>> CRAT table.
>>
>> Signed-off-by: Hanjun Guo <guohanjun@...wei.com>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> index 6a250f8..ed77b109 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> @@ -764,6 +764,11 @@ int kfd_create_crat_image_acpi(void **crat_image, size_t *size)
>>   
>>   	*crat_image = NULL;
>>   
>> +	if (ignore_crat) {
> 
> A conflicting change in this area was just submitted on Monday to
> amd-staging-drm-next. You'll need to rebase your patch. It should be
> straight-forward. ignore_crat was replaced with a function call
> kfd_ignore_crat().
> 
> Other than that, your patch series looks good to me. If I don't see an
> update from you in a day or two, I'll fix it up myself and add my R-b.

Please fix it up by yourself, thanks a lot for the help!

Regards
Hanjun