lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Aug 2020 18:02:45 -0700 From: Guenter Roeck <linux@...ck-us.net> To: 啟原黃 <u0084500@...il.com> Cc: Greg KH <gregkh@...uxfoundation.org>, robh+dt@...nel.org, matthias.bgg@...il.com, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, cy_huang <cy_huang@...htek.com>, gene_chen@...htek.com, linux-usb@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver On 8/26/20 5:59 PM, 啟原黃 wrote: [ ... ] >>> +static int mt6360_tcpc_remove(struct platform_device *pdev) >>> +{ >>> + struct mt6360_tcpc_info *mti = platform_get_drvdata(pdev); >>> + >>> + tcpci_unregister_port(mti->tcpci); >> >> That leaves interrupts enabled, which might be racy >> because interrupts are still enabled here. > M..., yes, it will cause the race condition during module remove. > I'll add disable_irq before tcpci unregister to prevent it. Or just set TCPC_ALERT_MASK to 0, as in tcpci.c. Guenter
Powered by blists - more mailing lists