linux-kernel - Re: [PATCH v2 02/11] cpuidle: Fixup IRQ state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200827010636.GB1939707@google.com>
Date:   Wed, 26 Aug 2020 21:06:36 -0400
From:   Joel Fernandes <joel@...lfernandes.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, mingo@...nel.org, will@...nel.org,
        npiggin@...il.com, elver@...gle.com, jgross@...e.com,
        paulmck@...nel.org, rostedt@...dmis.org, svens@...ux.ibm.com,
        tglx@...utronix.de
Subject: Re: [PATCH v2 02/11] cpuidle: Fixup IRQ state

On Fri, Aug 21, 2020 at 07:36:43PM +0200, Rafael J. Wysocki wrote:
> On Friday, August 21, 2020 10:47:40 AM CEST Peter Zijlstra wrote:
> > Match the pattern elsewhere in this file.
> > 
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> > Tested-by: Marco Elver <elver@...gle.com>
> 
> For all patches in the series:
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>

thanks,

 - Joel

> 
> > ---
> >  drivers/cpuidle/cpuidle.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > --- a/drivers/cpuidle/cpuidle.c
> > +++ b/drivers/cpuidle/cpuidle.c
> > @@ -153,7 +153,8 @@ static void enter_s2idle_proper(struct c
> >  	 */
> >  	stop_critical_timings();
> >  	drv->states[index].enter_s2idle(dev, drv, index);
> > -	WARN_ON(!irqs_disabled());
> > +	if (WARN_ON_ONCE(!irqs_disabled()))
> > +		local_irq_disable();
> >  	/*
> >  	 * timekeeping_resume() that will be called by tick_unfreeze() for the
> >  	 * first CPU executing it calls functions containing RCU read-side
> > 
> > 
> > 
> 
> 
> 
>