linux-kernel - Re: [PATCH] iio: adc: exynos_adc: Replace indio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200827065625.GB17964@kozik-lap>
Date:   Thu, 27 Aug 2020 08:56:25 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        jic23@...nel.org, kgene@...nel.org,
        Sergiu Cuciurean <sergiu.cuciurean@...log.com>
Subject: Re: [PATCH] iio: adc: exynos_adc: Replace indio_dev->mlock with own
 device lock

On Wed, Aug 26, 2020 at 04:22:03PM +0300, Alexandru Ardelean wrote:
> From: Sergiu Cuciurean <sergiu.cuciurean@...log.com>
> 
> As part of the general cleanup of indio_dev->mlock, this change replaces
> it with a local lock, to protect potential concurrent access to the
> completion callback during a conversion.

I don't know the bigger picture (and no links here for general cleanup)
but I assume it is part of wider work and that mlock is unwanted. In
such case:

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

If it is part of some bigger work, please put a link to lore.kernel.org
under separators ---, so everyone can get the context.


Best regards,
Krzysztof

> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@...log.com>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> ---
>  drivers/iio/adc/exynos_adc.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>