lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Aug 2020 09:44:31 +0100 From: Christoph Hellwig <hch@...radead.org> To: "Matthew Wilcox (Oracle)" <willy@...radead.org> Cc: linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, "Darrick J . Wong" <darrick.wong@...cle.com>, linux-block@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 04/11] block: Add bio_for_each_thp_segment_all On Mon, Aug 24, 2020 at 04:16:53PM +0100, Matthew Wilcox (Oracle) wrote: > Iterate once for each THP instead of once for each base page. FYI, I've always been wondering if bio_for_each_segment_all is the right interface for the I/O completions, because we generally don't need the fake bvecs for each page. Only the first page can have an offset, and only the last page can be end earlier than the end of the page size. It would seem way more efficient to just have a helper that extracts the offset and end, and just use that in a loop that does the way cheaper iteration over the physical addresses only. This might (or might) not be a good time to switch to that model for iomap.
Powered by blists - more mailing lists