linux-kernel - Re: [PATCH v2] Input: bcm-keypad - Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Aug 2020 12:04:47 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-input <linux-input@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Input: bcm-keypad - Simplify with dev_err_probe()

On Wed, Aug 26, 2020 at 11:04 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe() and devm_clk_get_optional().  Less code and the error
> value gets printed.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>
> ---
>
> Changes since v1:
> 1. Use also devm_clk_get_optional()
> ---
>  drivers/input/keyboard/bcm-keypad.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
> index 2b771c3a5578..23e11b4efd13 100644
> --- a/drivers/input/keyboard/bcm-keypad.c
> +++ b/drivers/input/keyboard/bcm-keypad.c
> @@ -376,17 +376,11 @@ static int bcm_kp_probe(struct platform_device *pdev)
>                 return PTR_ERR(kp->base);
>
>         /* Enable clock */
> -       kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
> +       kp->clk = devm_clk_get_optional(&pdev->dev, "peri_clk");
>         if (IS_ERR(kp->clk)) {
> -               error = PTR_ERR(kp->clk);
> -               if (error != -ENOENT) {
> -                       if (error != -EPROBE_DEFER)
> -                               dev_err(&pdev->dev, "Failed to get clock\n");
> -                       return error;
> -               }
> -               dev_dbg(&pdev->dev,
> -                       "No clock specified. Assuming it's enabled\n");
> -               kp->clk = NULL;
> +               return dev_err_probe(&pdev->dev, error, "Failed to get clock\n");
> +       } else if (!kp->clk) {
> +               dev_dbg(&pdev->dev, "No clock specified. Assuming it's enabled\n");
>         } else {
>                 unsigned int desired_rate;
>                 long actual_rate;
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko