linux-kernel - Re: [PATCH 22/24] Input: sis_i2c - Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Aug 2020 12:18:06 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bastien Nocera <hadess@...ess.net>,
        Sangwon Jee <jeesw@...fas.com>,
        Eugen Hristev <eugen.hristev@...rochip.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-input <linux-input@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH 22/24] Input: sis_i2c - Simplify with dev_err_probe()

On Wed, Aug 26, 2020 at 9:20 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/input/touchscreen/sis_i2c.c | 20 ++++++--------------
>  1 file changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/input/touchscreen/sis_i2c.c b/drivers/input/touchscreen/sis_i2c.c
> index 6274555f1673..348a2ba9b7c9 100644
> --- a/drivers/input/touchscreen/sis_i2c.c
> +++ b/drivers/input/touchscreen/sis_i2c.c
> @@ -311,23 +311,15 @@ static int sis_ts_probe(struct i2c_client *client,
>
>         ts->attn_gpio = devm_gpiod_get_optional(&client->dev,
>                                                 "attn", GPIOD_IN);
> -       if (IS_ERR(ts->attn_gpio)) {
> -               error = PTR_ERR(ts->attn_gpio);
> -               if (error != -EPROBE_DEFER)
> -                       dev_err(&client->dev,
> -                               "Failed to get attention GPIO: %d\n", error);
> -               return error;
> -       }
> +       if (IS_ERR(ts->attn_gpio))
> +               return dev_err_probe(&client->dev, PTR_ERR(ts->attn_gpio),
> +                                    "Failed to get attention GPIO\n");
>
>         ts->reset_gpio = devm_gpiod_get_optional(&client->dev,
>                                                  "reset", GPIOD_OUT_LOW);
> -       if (IS_ERR(ts->reset_gpio)) {
> -               error = PTR_ERR(ts->reset_gpio);
> -               if (error != -EPROBE_DEFER)
> -                       dev_err(&client->dev,
> -                               "Failed to get reset GPIO: %d\n", error);
> -               return error;
> -       }
> +       if (IS_ERR(ts->reset_gpio))
> +               return dev_err_probe(&client->dev, PTR_ERR(ts->reset_gpio),
> +                                    "Failed to get reset GPIO\n");
>
>         sis_ts_reset(ts);
>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko