linux-kernel - Re: [PATCH v2] memory: omap-gpmc: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4d64ed6-2bd6-9b6e-63e1-59eb50157b87@ti.com>
Date:   Thu, 27 Aug 2020 12:27:00 +0300
From:   Roger Quadros <rogerq@...com>
To:     YueHaibing <yuehaibing@...wei.com>, <tony@...mide.com>,
        <krzk@...nel.org>, <ladis@...ux-mips.org>, <bbrezillon@...nel.org>,
        <peter.ujfalusi@...com>
CC:     <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] memory: omap-gpmc: Fix build error without CONFIG_OF

Hi,

On 26/08/2020 15:59, YueHaibing wrote:
> If CONFIG_OF is n, gcc fails:
> 
> drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings':
> omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt'
> 
> Add gpmc_read_settings_dt() helper function to fix this.
> 
> Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: add gpmc_read_settings_dt() stub
> ---
>   drivers/memory/omap-gpmc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index cd9e80748591..02c0c694ecaf 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2310,6 +2310,9 @@ static void gpmc_probe_dt_children(struct platform_device *pdev)
>   	}
>   }
>   #else
> +void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p)
> +{

I will suggest to set gpmc_settings data structure to zero here so that
the caller doesn't proceed with random/invalid settings.

> +}
>   static int gpmc_probe_dt(struct platform_device *pdev)
>   {
>   	return 0;
> 

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki