lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Aug 2020 20:59:39 -0500 From: Bjorn Andersson <bjorn.andersson@...aro.org> To: Stephen Boyd <swboyd@...omium.org> Cc: Kishon Vijay Abraham I <kishon@...com>, Vinod Koul <vkoul@...nel.org>, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, Jeykumar Sankaran <jsanka@...eaurora.org>, Chandan Uddaraju <chandanu@...eaurora.org>, Vara Reddy <varar@...eaurora.org>, Tanmay Shah <tanmay@...eaurora.org>, Manu Gautam <mgautam@...eaurora.org>, Sandeep Maheswaram <sanm@...eaurora.org>, Douglas Anderson <dianders@...omium.org>, Sean Paul <seanpaul@...omium.org>, Jonathan Marek <jonathan@...ek.ca>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Rob Clark <robdclark@...omium.org> Subject: Re: [PATCH v1 5/9] phy: qcom-qmp: Get dp_com I/O resource by index On Wed 26 Aug 16:32 CDT 2020, Stephen Boyd wrote: > Quoting Bjorn Andersson (2020-08-25 21:36:16) > > On Tue 25 Aug 21:47 CDT 2020, Stephen Boyd wrote: > > > > > The dp_com resource is always at index 1 according to the dts files in > > > the kernel. Get this resource by index so that we don't need to make > > > future additions to the DT binding use 'reg-names'. > > > > > > > Afaict the DT binding for the USB/DP phy defines that there should be a > > reg name of "dp_com" and the current dts files all specifies this. Am I > > missing something? > > Yes the binding enforces this but this patch is removing that > enforcement and instead mandating that dp_com is always at index 1 (i.e. > the second one) so that we can add the DP serdes region directly after > and avoid adding yet another reg-names property. I changed the binding > for this usb3-dp phy compatible to make reg-names optional as well. I > don't see any gain from using reg-names. > Thanks for the explanation, I don't have any objections to this. > > > > PS. Why isn't this a devm_platform_ioremap_resource{,_byname}()? > > Sure. I'll roll that into this patch. Thanks, Bjorn
Powered by blists - more mailing lists