linux-kernel - Re: [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f844b044-9ac4-094d-0ff8-feaceb50185f@roeck-us.net>
Date:   Wed, 26 Aug 2020 19:07:03 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     啟原黃 <u0084500@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, robh+dt@...nel.org,
        matthias.bgg@...il.com,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        cy_huang <cy_huang@...htek.com>, gene_chen@...htek.com,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C
 driver

On 8/26/20 6:11 PM, 啟原黃 wrote:
> Guenter Roeck <linux@...ck-us.net> 於 2020年8月27日 週四 上午9:02寫道：
>>
>> On 8/26/20 5:59 PM, 啟原黃 wrote:
>> [ ... ]
>>>>> +static int mt6360_tcpc_remove(struct platform_device *pdev)
>>>>> +{
>>>>> +     struct mt6360_tcpc_info *mti = platform_get_drvdata(pdev);
>>>>> +
>>>>> +     tcpci_unregister_port(mti->tcpci);
>>>>
>>>> That leaves interrupts enabled, which might be racy
>>>> because interrupts are still enabled here.
>>> M..., yes, it will cause the race condition during module remove.
>>> I'll add disable_irq before tcpci unregister to prevent it.
>>
>> Or just set TCPC_ALERT_MASK to 0, as in tcpci.c.
> Both are right, Thx. I'll choose one.
> 
> BTW, it seems enum typec_cc_status is used by tcpci.h.
> If I don't include tcpm.h, it will raise a warning during the compile time.

Ok, thanks for the note (that means tcpci.h should include
linux/usb/tcpm.h, really).

Guenter