linux-kernel - [PATCH 19/23] block/sx8: use ASSERT_FAIL()/ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c0016667db5c6c9d5c0c98853ce3db2b2ef2f851.1598518912.git.brookxu@tencent.com>
Date:   Thu, 27 Aug 2020 18:14:24 +0800
From:   Chunguang Xu <brookxu.cn@...il.com>
To:     arnd@...db.de
Cc:     rppt@...nel.org, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH 19/23] block/sx8: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT()
may be realized through them, thus reducing code redundancy and
facilitating problem analysis.

Signed-off-by: Chunguang Xu <brookxu@...cent.com>
---
 drivers/block/sx8.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c
index 4478eb7..d9adcf3 100644
--- a/drivers/block/sx8.c
+++ b/drivers/block/sx8.c
@@ -93,11 +93,7 @@
 #ifdef CARM_NDEBUG
 #define assert(expr)
 #else
-#define assert(expr) \
-        if(unlikely(!(expr))) {                                   \
-        printk(KERN_ERR "Assertion failed! %s,%s,%s,line=%d\n", \
-	#expr, __FILE__, __func__, __LINE__);          \
-        }
+#define assert(expr) ASSERT_WARN(expr)
 #endif
 
 /* defines only for the constants which don't work well as enums */
-- 
1.8.3.1