linux-kernel - Re: [PATCH 1/1] USB: PHY: JZ4770: Fix static checker warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mu2gi6gw.fsf@kernel.org>
Date:   Thu, 27 Aug 2020 16:06:07 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>, gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhenwenjin@...il.com, sernia.zhou@...mail.com,
        yanfei.li@...enic.com, rick.tyliu@...enic.com,
        aric.pzqi@...enic.com, dongsheng.qiu@...enic.com
Subject: Re: [PATCH 1/1] USB: PHY: JZ4770: Fix static checker warning.

周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com> writes:

> The commit 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new
> Ingenic SoCs.") introduced the initialization function for different
> chips, but left the relevant code involved in the resetting process
> in the original function, resulting in uninitialized variable calls.
>
> Fixes: 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new
> Ingenic SoCs.").

These two lines here, they should be one line :-)

For the Fixes: line, you shouldn't worry about the 72-char limit. Also,
when resending, don't add a blank line between Fixes and Signed-off-by
and since this is a bug fix, it seems like Cc: stable is in order.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (858 bytes)