linux-kernel - Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55ad40ff-dcc1-5051-65d2-24201c471a8f@roeck-us.net>
Date:   Thu, 27 Aug 2020 06:40:14 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Zhen Lei <thunder.leizhen@...wei.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        linux-watchdog <linux-watchdog@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] watchdog: remove unneeded inclusion of
 <uapi/linux/sched/types.h>

On 8/26/20 11:21 PM, Zhen Lei wrote:
> There has been no reference to "struct sched_param" since
> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
> there's no need to include <uapi/linux/sched/types.h> any more, delete
> it.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/watchdog_dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
> index 6798addabd5a067..0f18fa2433310b0 100644
> --- a/drivers/watchdog/watchdog_dev.c
> +++ b/drivers/watchdog/watchdog_dev.c
> @@ -43,8 +43,6 @@
>  #include <linux/watchdog.h>	/* For watchdog specific items */
>  #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
>  
> -#include <uapi/linux/sched/types.h>	/* For struct sched_param */
> -
>  #include "watchdog_core.h"
>  #include "watchdog_pretimeout.h"
>  
>