linux-kernel - Re: [PATCH 1/3] fpga manager: xilinx-spi: remove stray comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Aug 2020 16:28:51 +0200
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     Moritz Fischer <mdf@...nel.org>
Cc:     linux-fpga@...r.kernel.org, Tom Rix <trix@...hat.com>,
        Michal Simek <michal.simek@...inx.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Anatolij Gustschin <agust@...x.de>
Subject: Re: [PATCH 1/3] fpga manager: xilinx-spi: remove stray comment

Hi Moritz,

On 20/08/20 06:11, Moritz Fischer wrote:
> On Mon, Aug 17, 2020 at 06:59:09PM +0200, Luca Ceresoli wrote:
>> Remove comment committed by mistake.
>>
>> Fixes: dd2784c01d93 ("fpga manager: xilinx-spi: check INIT_B pin during write_init")
>> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
>> ---
>>  drivers/fpga/xilinx-spi.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c
>> index 2967aa2a74e2..502fae0d1d85 100644
>> --- a/drivers/fpga/xilinx-spi.c
>> +++ b/drivers/fpga/xilinx-spi.c
>> @@ -57,7 +57,6 @@ static int wait_for_init_b(struct fpga_manager *mgr, int value,
>>  
>>  	if (conf->init_b) {
>>  		while (time_before(jiffies, timeout)) {
>> -			/* dump_state(conf, "wait for init_d .."); */
>>  			if (gpiod_get_value(conf->init_b) == value)
>>  				return 0;
>>  			usleep_range(100, 400);
>> -- 
>> 2.28.0
>>
> 
> Applied to for-next,
> 
> Thanks
> 

Thanks, but still I don't see it. Missing push?

As I'm sending a v2 patch series, I'll keep this patch for now, just in
case.

-- 
Luca