linux-kernel - Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Aug 2020 17:26:40 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     周琰杰 <zhouyanjie@...yeetech.com>,
        周正 <sernia.zhou@...mail.com>,
        漆鹏振 <aric.pzqi@...enic.com>, od@...c.me,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written
 to HW register

Hi,

Paul Cercueil <paul@...pouillou.net> writes:
>>>>>   @@ -246,9 +241,8 @@ static void x1830_usb_phy_init(struct usb_phy
>>>>>  *phy)
>>>>>    		USBPCR1_DMPD | USBPCR1_DPPD;
>>>>>    	writel(reg, priv->base + REG_USBPCR1_OFFSET);
>>>>> 
>>>>>   -	reg = USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT
>>>>>  |	USBPCR_TXPREEMPHTUNE |
>>>>>   +	return USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT |
>>>>>  USBPCR_TXPREEMPHTUNE |
>>>>>    		USBPCR_COMMONONN | USBPCR_POR;
>>>>>   -	writel(reg, priv->base + REG_USBPCR_OFFSET);
>>>> 
>>>>  not a bug fix
>>> 
>>>  Well, if you don't like my bug fix, next time wait for my 
>>> Reviewed-by.
>> 
>> why so angry? Take a break every once in a while. Besides, someone 
>> else
>> already sent the oneliner before you ;-)
>
> I'm just pissed that this patch has not been tested. I don't like 
> sloppy work.

yeah, s**t happens

>> In any case, why should I wait for your Reviewed-by? Get maintainer
>> doesn't list you as the maintainer for it. Do you want to update
>> MAINTAINERS by any chance?
>
> Yes, I thought I was (I'm maintainer of all Ingenic drivers), that also 
> explains why I wasn't Cc'd for the oneliner patch you mentioned...
>
> IIRC Zhou has a patch to move the driver to drivers/phy/, I'll add 
> myself as maintainer once it's moved there.

makes sense

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (858 bytes)