linux-kernel - Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Aug 2020 13:16:07 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Maya Erez <merez@...eaurora.org>, wil6210@....qualcomm.com
Subject: Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed
 function parameter 'ptr_'

On Thu, 27 Aug 2020, Kalle Valo wrote:

> Lee Jones <lee.jones@...aro.org> writes:
> 
> > On Thu, 27 Aug 2020, Lee Jones wrote:
> >
> >> On Wed, 26 Aug 2020, Kalle Valo wrote:
> >> 
> >> > Lee Jones <lee.jones@...aro.org> wrote:
> >> > 
> >> > > Fixes the following W=1 kernel build warning(s):
> >> > > 
> >> > >  drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function
> >> > > parameter or member 'ptr_' not described in 'wmi_buffer_block'
> >> > >  drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess
> >> > > function parameter 'ptr' description in 'wmi_buffer_block'
> >> > > 
> >> > > Cc: Maya Erez <merez@...eaurora.org>
> >> > > Cc: Kalle Valo <kvalo@...eaurora.org>
> >> > > Cc: "David S. Miller" <davem@...emloft.net>
> >> > > Cc: Jakub Kicinski <kuba@...nel.org>
> >> > > Cc: linux-wireless@...r.kernel.org
> >> > > Cc: wil6210@....qualcomm.com
> >> > > Cc: netdev@...r.kernel.org
> >> > > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> >> > 
> >> > Failed to apply:
> >> > 
> >> > error: patch failed: drivers/net/wireless/ath/wil6210/wmi.c:266
> >> > error: drivers/net/wireless/ath/wil6210/wmi.c: patch does not apply
> >> > stg import: Diff does not apply cleanly
> >> > 
> >> > Patch set to Changes Requested.
> >> 
> >> Are you applying them in order?
> >> 
> >> It may be affected by:
> >> 
> >>  wireless: ath: wil6210: wmi: Fix formatting and demote
> >> non-conforming function headers
> >> 
> >> I'll also rebase onto the latest -next and resubmit.
> >
> > I just rebased all 3 sets onto the latest -next (next-20200827)
> > without issue.  Not sure what problem you're seeing.  Did you apply
> > the first set before attempting the second?
> 
> I can't remember the order, patchwork sorts them based on the order they
> have been submitted and that's what I usually use.
> 
> Do note that there's a separate tree for drivers in
> drivers/net/wireless/ath:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/
> 
> And it takes a week or two before patches go to linux-next.

Understood.  Thank you.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog