lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Aug 2020 17:01:50 -0700 From: Joe Perches <joe@...ches.com> To: Finn Thain <fthain@...egraphics.com.au> Cc: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Denis Efremov <efremov@...ux.com>, "David S. Miller" <davem@...emloft.net>, Song Liu <song@...nel.org>, Al Viro <viro@...iv.linux.org.uk>, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org, linux-raid@...r.kernel.org, linux-scsi@...r.kernel.org, linux-m68k@...ts.linux-m68k.org Subject: Re: [PATCH 17/19] z2ram: reindent On Fri, 2020-08-28 at 09:21 +1000, Finn Thain wrote: > > @@ -109,34 +111,28 @@ static void get_z2ram(void) > ... > > } > > - > > - return; > > } > > > > It would be good to have a semantic patch for that change. > > > > > - if (z2ram_map[z2ram_size] == 0) { > > + if (z2ram_map[z2ram_size] == 0) > > break; > > - } > > > > And that one. > > Reason being, a semantic patch only has to be debugged once, whereas > manual churn has to be done correctly over and over again. checkpatch already does this.
Powered by blists - more mailing lists