linux-kernel - Re: [PATCH] sparse: use static inline for __chk_{user,io}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200828201516.p33577vucl6ke4j5@ltop.local>
Date:   Fri, 28 Aug 2020 22:15:16 +0200
From:   Luc Van Oostenryck <luc.vanoostenryck@...il.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sparse: use static inline for __chk_{user,io}_ptr()

On Fri, Aug 28, 2020 at 09:04:28PM +0200, Miguel Ojeda wrote:
> Hi Luc,
> 
> On Fri, Aug 28, 2020 at 10:53 AM Luc Van Oostenryck
> <luc.vanoostenryck@...il.com> wrote:
> >
> > Hi Miguel,
> >
> > Could you also take this patch in your queue?
> > It has already be sent twice but ignored by the other channels.
> 
> Yeah, no problem. However, what about all those emails from the test
> bot? Is the bot using an old version of sparse or something like that?

Thanks.
The bot uses the very latest sparse version (which is very nice)
but is giving here false warnings. The change in the patch has as
consequence to change related warnings:
	: ...
	:   expected void const volatile [noderef] __user *
	:   got ...
into:
	: ...
	:   expected void const volatile [noderef] __user *ptr
	:   got ...

But to the bot, any change to the content of the warning itself
or its associated info is presented as a new warning.
I've talked to the bot's guys about this problem and they've
replied that they're seriously considering to change this behaviour.

Best regards,
-- Luc