linux-kernel - Re: [PATCH 6/6] gpio: zynq: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb949e25-ae67-bc62-378d-7f73de9b2c07@xilinx.com>
Date:   Fri, 28 Aug 2020 07:20:16 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>, Ray Jui <rjui@...adcom.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com, Keerthy <j-keerthy@...com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 6/6] gpio: zynq: Simplify with dev_err_probe()



On 27. 08. 20 22:08, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and also it prints the error value.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/gpio/gpio-zynq.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index 53d1387592fd..0b5a17ab996f 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -929,11 +929,9 @@ static int zynq_gpio_probe(struct platform_device *pdev)
>  
>  	/* Retrieve GPIO clock */
>  	gpio->clk = devm_clk_get(&pdev->dev, NULL);
> -	if (IS_ERR(gpio->clk)) {
> -		if (PTR_ERR(gpio->clk) != -EPROBE_DEFER)
> -			dev_err(&pdev->dev, "input clock not found.\n");
> -		return PTR_ERR(gpio->clk);
> -	}
> +	if (IS_ERR(gpio->clk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(gpio->clk), "input clock not found.\n");
> +
>  	ret = clk_prepare_enable(gpio->clk);
>  	if (ret) {
>  		dev_err(&pdev->dev, "Unable to enable clock.\n");
> 

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal