linux-kernel - Re: [PATCH] Remove unneeded variable t1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200828065737.GA14575@gondor.apana.org.au>
Date:   Fri, 28 Aug 2020 16:57:37 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, vulab@...as.ac.cn
Subject: Re: [PATCH] Remove unneeded variable t1

Xu Wang <vulab@...as.ac.cn> wrote:
> Remove unneeded variable t1 seed_encrypt() and
> seed_decrypt().
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
> crypto/seed.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/crypto/seed.c b/crypto/seed.c
> index 5e3bef3a617d..69b3058d6a32 100644
> --- a/crypto/seed.c
> +++ b/crypto/seed.c
> @@ -366,7 +366,7 @@ static void seed_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
>        const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
>        const __be32 *src = (const __be32 *)in;
>        __be32 *dst = (__be32 *)out;
> -       u32 x1, x2, x3, x4, t0, t1;
> +       u32 x1, x2, x3, x4, t0;
>        const u32 *ks = ctx->keysched;
> 
>        x1 = be32_to_cpu(src[0]);
> @@ -404,7 +404,7 @@ static void seed_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
>        const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
>        const __be32 *src = (const __be32 *)in;
>        __be32 *dst = (__be32 *)out;
> -       u32 x1, x2, x3, x4, t0, t1;
> +       u32 x1, x2, x3, x4, t0;
>        const u32 *ks = ctx->keysched;
> 
>        x1 = be32_to_cpu(src[0]);

This doesn't even compile!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt