linux-kernel - Re: [PATCH 3/3] ARM: tegra: Pass multiple versions in opp-supported-hw property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0763074-859f-fccb-dde4-03d1a50ea021@gmail.com>
Date:   Fri, 28 Aug 2020 10:37:59 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>
Cc:     linux-pm@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Rafael Wysocki <rjw@...ysocki.net>,
        Stephen Boyd <sboyd@...nel.org>, Nishanth Menon <nm@...com>,
        Stephan Gerhold <stephan@...hold.net>,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ARM: tegra: Pass multiple versions in
 opp-supported-hw property

26.08.2020 14:50, Viresh Kumar пишет:
> We can now pass multiple versions in "opp-supported-hw" property, lets
> do that and simplify the tables a bit.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> ---
> Dmitry, I think there is further scope of simplifying stuff here by
> using the opp-microvolt-<name> property and corresponding
> dev_pm_opp_set_prop_name() call.
> ---
>  .../boot/dts/tegra20-cpu-opp-microvolt.dtsi   |  36 -
>  arch/arm/boot/dts/tegra20-cpu-opp.dtsi        |  67 +-
>  .../boot/dts/tegra30-cpu-opp-microvolt.dtsi   | 512 ---------
>  arch/arm/boot/dts/tegra30-cpu-opp.dtsi        | 986 +++---------------
>  4 files changed, 149 insertions(+), 1452 deletions(-)

Hello, Viresh!

Thank you very much! Very nice cleanup! I changed my OPP-gen tool to
produce the new OPP format and then comapared the result to yours
change, the result is matching.

...
> diff --git a/arch/arm/boot/dts/tegra30-cpu-opp.dtsi b/arch/arm/boot/dts/tegra30-cpu-opp.dtsi
...
> -		opp@...0000000,975,3,7 {
> -			clock-latency-ns = <100000>;
> -			opp-supported-hw = <0x08 0x0080>;
> -			opp-hz = /bits/ 64 <1000000000>;
> +			opp-supported-hw = <0x0F 0x0001>,
> +				<0x01 0x0002>,
> +				<0x01 0x0010>,
> +				<0x01 0x0080>,
> +				<0x01 0x0100>;
> +			opp-hz = /bits/ 64 <475000000>;
>  		};

The only very minor difference between my OPP-gen result and yours is
that the above hunk has inconsistent single-column formatting, while all
others are two-column.

Reviewed-by: Dmitry Osipenko <digetx@...il.com>
Tested-by: Dmitry Osipenko <digetx@...il.com>