linux-kernel - Re: [PATCH V2] serial: qcom_geni_serial: To correct QUP Version detection logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Aug 2020 10:18:49 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Paras Sharma <parashar@...eaurora.org>
Cc:     Jiri Slaby <jslaby@...e.com>, linux-arm-msm@...r.kernel.org,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] serial: qcom_geni_serial: To correct QUP Version
 detection logic

On Tue, Aug 11, 2020 at 10:23:30AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 11, 2020 at 01:13:14PM +0530, Paras Sharma wrote:
> > The current implementation reduces the sampling rate by half
> > if qup HW version greater is than 2.5 by checking if the geni
> > SE major version is greater than 2 and geni SE minor version
> > is greater than 5.
> > 
> > This implementation fails when the version is 3 or greater.
> > 
> > Hence by adding the another check for geni SE major version,
> > this problem can be solved.
> > 
> > Signed-off-by: Paras Sharma <parashar@...eaurora.org>
> > ---
> >  drivers/tty/serial/qcom_geni_serial.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Should this go to stable kernels?  If so, how far back?  What git commit
> id is this patch fixing?  And if so, why not put a Fixes: tag on this as
> well?

Dropped from my review queue due to lack of response, please fix up and
resend when you wish to have it reviewed again...

greg k-h