linux-kernel - Re: [PATCH 1/1] mfd: khadas-mcu: Fix randconfig 'unused-const-variable' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Aug 2020 11:19:44 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-amlogic@...ts.infradead.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/1] mfd: khadas-mcu: Fix randconfig
 'unused-const-variable' warning

Hi Lee,

On 28/08/2020 10:50, Lee Jones wrote:
> When testing with !OF, the build system reports:
> 
>>> drivers/mfd/khadas-mcu.c:125:34: warning: unused variable 'khadas_mcu_of_match' [-Wunused-const-variable]
>    static const struct of_device_id khadas_mcu_of_match[] = {
>                                     ^
> 
> Cc: Neil Armstrong <narmstrong@...libre.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/mfd/khadas-mcu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/khadas-mcu.c b/drivers/mfd/khadas-mcu.c
> index 44d5bb462daba..f3d418810693c 100644
> --- a/drivers/mfd/khadas-mcu.c
> +++ b/drivers/mfd/khadas-mcu.c
> @@ -122,11 +122,13 @@ static int khadas_mcu_probe(struct i2c_client *client,
>  	return 0;
>  }
>  
> +#ifdef CONFIG_OF
>  static const struct of_device_id khadas_mcu_of_match[] = {
>  	{ .compatible = "khadas,mcu", },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, khadas_mcu_of_match);
> +#endif
>  
>  static struct i2c_driver khadas_mcu_driver = {
>  	.driver = {
> 
Thanks for the patch,

Acked-by: Neil Armstrong <narmstrong@...libre.com>