linux-kernel - Re: [PATCH v2 3/3] dyndbg: fix problem parsing format="foo bar"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200828103106.GE1470435@kroah.com>
Date:   Fri, 28 Aug 2020 12:31:06 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jim Cromie <jim.cromie@...il.com>
Cc:     jbaron@...mai.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] dyndbg: fix problem parsing format="foo bar"

On Tue, Aug 25, 2020 at 11:33:39AM -0600, Jim Cromie wrote:
>  14775b049642 dyndbg: accept query terms like file=bar and module=foo
> 

What does that above line mean???

> That commit broke on a tokenization modality where a word could start
> with a quote, but couldnt continue with one.  So the above would
> tokenize as 'format="foo' and 'bar"', and fail hard.
> 
> This commit fixes the tokenizer by terminating an unquoted token on
> the '=', avoiding that problem.  And since ddebug-parse-query will
> never see a combined 'keyword=value', revert those parts of the
> previous commit.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>

Again, a Fixes: tag, and fix up your text above please.

Can you do this and send a v3 of this series and any other pending
dyndbg fixes for 5.9-final?

thanks,

greg k-h