linux-kernel - Re: [PATCH 06/12] soc/tegra: pmc: provide usb sleepwalk register map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202008281849.FCXeSTmY%lkp@intel.com>
Date:   Fri, 28 Aug 2020 18:53:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     JC Kuo <jckuo@...dia.com>, gregkh@...uxfoundation.org,
        thierry.reding@...il.com, robh@...nel.org, jonathanh@...dia.com,
        kishon@...com
Cc:     kbuild-all@...ts.01.org, linux-tegra@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, nkristam@...dia.com
Subject: Re: [PATCH 06/12] soc/tegra: pmc: provide usb sleepwalk register map

Hi JC,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on robh/for-next usb/usb-testing char-misc/char-misc-testing staging/staging-testing driver-core/driver-core-testing v5.9-rc2 next-20200827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/JC-Kuo/Tegra-XHCI-controller-ELPG-support/20200828-091337
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/soc/tegra/pmc.c:2537:5: warning: no previous prototype for 'tegra_pmc_regmap_readl' [-Wmissing-prototypes]
    2537 | int tegra_pmc_regmap_readl(void *context, unsigned int reg, unsigned int *val)
         |     ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/tegra/pmc.c:2545:5: warning: no previous prototype for 'tegra_pmc_regmap_writel' [-Wmissing-prototypes]
    2545 | int tegra_pmc_regmap_writel(void *context, unsigned int reg, unsigned int val)
         |     ^~~~~~~~~~~~~~~~~~~~~~~

# https://github.com/0day-ci/linux/commit/56def0140d21d6eeb92615ae6ec5f7e25095c37f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review JC-Kuo/Tegra-XHCI-controller-ELPG-support/20200828-091337
git checkout 56def0140d21d6eeb92615ae6ec5f7e25095c37f
vim +/tegra_pmc_regmap_readl +2537 drivers/soc/tegra/pmc.c

  2536	
> 2537	int tegra_pmc_regmap_readl(void *context, unsigned int reg, unsigned int *val)
  2538	{
  2539		struct tegra_pmc *pmc = context;
  2540	
  2541		*val = tegra_pmc_readl(pmc, reg);
  2542		return 0;
  2543	}
  2544	
> 2545	int tegra_pmc_regmap_writel(void *context, unsigned int reg, unsigned int val)
  2546	{
  2547		struct tegra_pmc *pmc = context;
  2548	
  2549		tegra_pmc_writel(pmc, val, reg);
  2550		return 0;
  2551	}
  2552	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (53062 bytes)