lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Aug 2020 17:12:44 -0700 From: "Dey, Megha" <megha.dey@...el.com> To: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org> CC: <x86@...nel.org>, Joerg Roedel <joro@...tes.org>, <iommu@...ts.linux-foundation.org>, <linux-hyperv@...r.kernel.org>, "Haiyang Zhang" <haiyangz@...rosoft.com>, Jon Derrick <jonathan.derrick@...el.com>, Lu Baolu <baolu.lu@...ux.intel.com>, Wei Liu <wei.liu@...nel.org>, "K. Y. Srinivasan" <kys@...rosoft.com>, Stephen Hemminger <sthemmin@...rosoft.com>, Steve Wahl <steve.wahl@....com>, Dimitri Sivanich <sivanich@....com>, "Russ Anderson" <rja@....com>, <linux-pci@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, <xen-devel@...ts.xenproject.org>, Juergen Gross <jgross@...e.com>, "Boris Ostrovsky" <boris.ostrovsky@...cle.com>, Stefano Stabellini <sstabellini@...nel.org>, Marc Zyngier <maz@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Jason Gunthorpe <jgg@...lanox.com>, Dave Jiang <dave.jiang@...el.com>, Alex Williamson <alex.williamson@...hat.com>, Jacob Pan <jacob.jun.pan@...el.com>, Baolu Lu <baolu.lu@...el.com>, Kevin Tian <kevin.tian@...el.com>, Dan Williams <dan.j.williams@...el.com> Subject: Re: [patch V2 15/46] x86/irq: Consolidate DMAR irq allocation Hi Thomas, On 8/26/2020 1:50 PM, Thomas Gleixner wrote: > On Wed, Aug 26 2020 at 20:32, Thomas Gleixner wrote: >> On Wed, Aug 26 2020 at 09:50, Megha Dey wrote: >>>> @@ -329,15 +329,15 @@ static struct irq_chip dmar_msi_controll >>>> static irq_hw_number_t dmar_msi_get_hwirq(struct msi_domain_info *info, >>>> msi_alloc_info_t *arg) >>>> { >>>> - return arg->dmar_id; >>>> + return arg->hwirq; >>> Shouldn't this return the arg->devid which gets set in dmar_alloc_hwirq? >> Indeed. > But for simplicity we can set arg->hwirq to the dmar id right in the > alloc function and then once the generic ops are enabled remove the dmar > callback completely True, can get rid of more code that way.
Powered by blists - more mailing lists