linux-kernel - Re: [PATCH 0/2] fix memleak when using pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200828160640.GA2157785@bjorn-Precision-5520>
Date:   Fri, 28 Aug 2020 11:06:40 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        bhelgaas@...gle.com, guohanjun@...wei.com,
        George Cherian <george.cherian@...vell.com>
Subject: Re: [PATCH 0/2] fix memleak when using pci_iounmap()

[+cc George]

On Fri, Aug 28, 2020 at 02:34:01PM +0800, Yang Yingliang wrote:
> config GENERIC_IOMAP is not selected on some arch, pci_iounmap()
> don't implement, when we using pci_iomap/pci_iounmap, it will
> lead to memory leak.
> This patch set moves the implemention of pci_iounmap() to
> lib/pci_iomap.c to fix this.
> 
> Yang Yingliang (2):
>   iomap: move some definitions to include/linux/io.h
>   pci: fix memleak when calling pci_iomap/unmap()
> 
>  include/asm-generic/pci_iomap.h |  2 ++
>  include/linux/io.h              | 36 ++++++++++++++++++++++++++
>  lib/iomap.c                     | 46 ---------------------------------
>  lib/pci_iomap.c                 |  8 ++++++
>  4 files changed, 46 insertions(+), 46 deletions(-)

I haven't looked at this yet (and won't because of the build issues),
but please note George's previous similar work:

https://lore.kernel.org/linux-pci/20200824132046.3114383-1-george.cherian@marvell.com/

I haven't compared them, so just FYI that we'll have to integrate them
somehow.

If/when you repost this, please run "git log --oneline" and match the
subject styles.  And add blank lines between paragraphs.  Use "()"
consistently after function names.  And please cc: George, of course.

Bjorn