linux-kernel - Re: [Patch v2 6/7] mm/hugetlb: return non-isolated page in the loop instead of break and check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80ca8de0-45cd-0c53-9f95-90957960c19d@oracle.com>
Date:   Fri, 28 Aug 2020 09:25:10 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Wei Yang <richard.weiyang@...ux.alibaba.com>,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org, bhe@...hat.com
Subject: Re: [Patch v2 6/7] mm/hugetlb: return non-isolated page in the loop
 instead of break and check

On 8/27/20 8:32 PM, Wei Yang wrote:
> Function dequeue_huge_page_node_exact() iterates the free list and
> return the first non-isolated one.
> 
> Instead of break and check the loop variant, we could return in the loop
> directly. This could reduce some redundant check.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...ux.alibaba.com>
> Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

Commit bbe88753bd42 (mm/hugetlb: make hugetlb migration callback CMA aware)
in v5.9-rc2 modified dequeue_huge_page_node_exact.  This patch will need
to be updated to take those changes into account.

-- 
Mike Kravetz