lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 29 Aug 2020 11:24:06 +0200
From:   Christoph Hellwig <>
To:     Linus Torvalds <>
Cc:     Christoph Hellwig <>, Al Viro <>,
        Michael Ellerman <>,
        the arch/x86 maintainers <>,
        Kees Cook <>,
        Linux Kernel Mailing List <>,
        linux-fsdevel <>,
        linux-arch <>,
        linuxppc-dev <>
Subject: Re: [PATCH 05/10] lkdtm: disable set_fs-based tests for

On Thu, Aug 27, 2020 at 11:06:28AM -0700, Linus Torvalds wrote:
> On Thu, Aug 27, 2020 at 8:00 AM Christoph Hellwig <> wrote:
> >
> > Once we can't manipulate the address limit, we also can't test what
> > happens when the manipulation is abused.
> Just remove these tests entirely.
> Once set_fs() doesn't exist on x86, the tests no longer make any sense
> what-so-ever, because test coverage will be basically zero.
> So don't make the code uglier just to maintain a fiction that
> something is tested when it isn't really.

Sure fine with me unless Kees screams.

Powered by blists - more mailing lists