linux-kernel - Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af6f0f6c-3b87-b87b-4b97-92c58466636d@posteo.de>
Date:   Sat, 29 Aug 2020 13:24:45 +0200
From:   Martin Kepplinger <martink@...teo.de>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        "Angus Ainslie (Purism)" <angus@...ea.ca>,
        Anson Huang <Anson.Huang@....com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing
 clock-cells to PMIC

On 28.08.20 21:22, Krzysztof Kozlowski wrote:
> The PMIC node can be a clock provider (for its 32 kHz clock) and authors
> of imx8mq-librem5-devkit.dts apparently wanted this because they added
> input clock and clock-output-names.
> 
> Add necessary clock-cells to the PMIC node.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 377591a0e6e9..40b43625f20f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -285,6 +285,7 @@
>  		pinctrl-0 = <&pinctrl_pmic>;
>  		clocks = <&pmic_osc>;
>  		clock-names = "osc";
> +		#clock-cells = <0>;
>  		clock-output-names = "pmic_clk";
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <3 GPIO_ACTIVE_LOW>;
> 

Hi Krzysztof,

Reviewed-and-tested-by: Martin Kepplinger <martink@...teo.de>

thanks for reviewing,

                            martin