linux-kernel - Re: [PATCH 1/4] extcon: max14577: Return error code of extcon_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Aug 2020 22:10:26 +0900
From:   Chanwoo Choi <chanwoo@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] extcon: max14577: Return error code of extcon_dev_allocate()

On Sat, Aug 29, 2020 at 9:46 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> devm_extcon_dev_allocate() can fail of multiple reasons.  The call
> returns proper error code on failure so pass it instead of fixed ENOMEM.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/extcon/extcon-max14577.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index cc47d626095c..ace523924e58 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -713,7 +713,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
>                                               max14577_extcon_cable);
>         if (IS_ERR(info->edev)) {
>                 dev_err(&pdev->dev, "failed to allocate memory for extcon\n");
> -               return -ENOMEM;
> +               return PTR_ERR(info->edev);
>         }
>
>         ret = devm_extcon_dev_register(&pdev->dev, info->edev);
> --
> 2.17.1
>

Applied them for patch1-4. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics