lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 28 Aug 2020 19:11:51 -0500
From:   Pierre-Louis Bossart <>
To:     Doug Anderson <>,
        Cheng-Yi Chiang <>
Cc:     Taniya Das <>,
        ALSA Development Mailing List <>,
        Banajit Goswami <>,
        Takashi Iwai <>,
        Rohit kumar <>,
        Patrick Lai <>,
        Ajit Pandey <>,
        Tzung-Bi Shih <>,
        Andy Gross <>,
        Dylan Reid <>,
        Stephan Gerhold <>,
        linux-arm-msm <>,
        Rob Herring <>,
        Bjorn Andersson <>,
        Linux ARM <>,
        Liam Girdwood <>,
        LKML <>,
        Mark Brown <>,
        Srini Kandagatla <>
Subject: Re: [PATCH v6 2/2] ASoC: qcom: sc7180: Add machine driver for sound
 card registration

>> +config SND_SOC_SC7180
>> +       tristate "SoC Machine driver for SC7180 boards"
>> +       depends on SND_SOC_QCOM

this depends is probably not necessary, the code is already in an if case.

>> +       select SND_SOC_QCOM_COMMON
>> +       select SND_SOC_LPASS_SC7180
>> +       select SND_SOC_MAX98357A
>> +       select SND_SOC_RT5682
> I haven't done any significant testing / review of your patch (I'm
> mostly sound-clueless), but I believe that the above needs to be
> "select SND_SOC_RT5682_I2C" atop the current top of the sound tree.
> When I fix that I can confirm that I see the rt5682 probe on
> sc7180-trogdor with Rob Clark's dts patch.

Ack, no one should select SND_SOC_RT5682 directly in machine drivers. 
now that the code is split between I2C and SoundWire parts.

There should probably be a depends on I2C as well?

Powered by blists - more mailing lists