linux-kernel - Re: [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73cb7fcd-df73-e287-7733-4ce657e5a758@arm.com>
Date:   Sun, 30 Aug 2020 10:26:45 +0100
From:   Alexandru Elisei <alexandru.elisei@....com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        xxm@...k-chips.com
Subject: Re: [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER

Hi Jonathan,

On 8/29/20 3:57 PM, Jonathan Cameron wrote:
> On Fri, 28 Aug 2020 18:42:42 +0100
> Alexandru Elisei <alexandru.elisei@....com> wrote:
>
>> Building the Rockchip saradc driver can trigger the following error if the
>> driver is compiled into the kernel, but the IIO triggered buffer is not:
>>
>> aarch64-linux-gnu-ld: drivers/iio/adc/rockchip_saradc.o: in function `rockchip_saradc_probe':
>> /path/to/linux/drivers/iio/adc/rockchip_saradc.c:427: undefined reference to `devm_iio_triggered_buffer_setup'
>>
>> This is because commit 4e130dc7b413 ("iio: adc: rockchip_saradc: Add
>> support iio buffers") added support for industrial I/O triggered buffers,
>> but didn't update Kconfig to build the required file. Fix that.
>>
>> Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
>> Signed-off-by: Alexandru Elisei <alexandru.elisei@....com>
> Sorry, I've had a patch queued to fix this for a while, but had a
> vacation just after merge window occurred that delayed me sending it out.
>
> Will send a pull sometime this weekend.
>
> Jonathan

That's great, thank you!

Thanks,
Alex