linux-kernel - Re: [PATCH] remoteproc: scp: add COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200830125601.468a24d8@coco.lan>
Date:   Sun, 30 Aug 2020 12:56:09 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Alexandre Courbot <acourbot@...omium.org>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ezequiel Garcia <ezequiel@...labora.com>,
        linux-media@...r.kernel.org, Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH] remoteproc: scp: add COMPILE_TEST dependency

Em Fri, 21 Aug 2020 20:58:32 +0900
Alexandre Courbot <acourbot@...omium.org> escreveu:

> This will improve this driver's build coverage.

There is a pending pull request for media which seems to depend
on this patch. Without it, COMPILE_TEST breaks at linux-media
git tree, if I pick it. See:

	https://lore.kernel.org/linux-media/20200830104650.0dd4d751@coco.lan/T/#t

The best here would be to get an ack from the remoteproc
maintainers to get this patch merged via the media tree.

Alternatively, this patch could be applied on a stable topic branch
at remoteproc tree, which would be merged at the media tree, or
cherry-picked on media after being committed at remoteproc tree.

Regards,
Mauro

> 
> Reported-by: Ezequiel Garcia <ezequiel@...labora.com>
> Signed-off-by: Alexandre Courbot <acourbot@...omium.org>
> ---
>  drivers/remoteproc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index c6659dfea7c7..d1fcada71017 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -43,7 +43,7 @@ config INGENIC_VPU_RPROC
>  
>  config MTK_SCP
>  	tristate "Mediatek SCP support"
> -	depends on ARCH_MEDIATEK
> +	depends on ARCH_MEDIATEK || COMPILE_TEST
>  	select RPMSG_MTK_SCP
>  	help
>  	  Say y here to support Mediatek's System Companion Processor (SCP) via



Thanks,
Mauro