linux-kernel - Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46f2119d-d94c-517f-46cf-10ec27c820f3@infradead.org>
Date:   Sun, 30 Aug 2020 08:01:10 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        David Howells <dhowells@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc

On 8/30/20 7:56 AM, Krzysztof Kozlowski wrote:
> On Wed, Aug 19, 2020 at 07:52:12PM +0200, Krzysztof Kozlowski wrote:
>> Fix W=1 compile warnings (invalid kerneldoc):
>>
>>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same'
>>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same'
>>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same'
>>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>> ---
>>  crypto/asymmetric_keys/asymmetric_type.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Hi David, Herbert,
> 
> Any comments here?
> 
> Best regards,
> Krzysztof

LGTM.  Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

-- 
~Randy