Message-ID: <edf38d68214247f486db3cc1f81ec404@shmbx04.spreadtrum.com>
Date:   Sun, 30 Aug 2020 16:36:42 +0000
From:   何小龙 (Leon He) <Leon.He@...soc.com>
To:     Paul Cercueil <paul@...pouillou.net>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Noralf Tronnes <noralf@...nnes.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Linus Walleij <linus.walleij@...aro.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "od@...c.me" <od@...c.me>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

> +struct ili9341 {
> +       struct drm_panel panel;
> +       struct mipi_dsi_device *dsi;
> +       const struct ili9341_pdata *pdata;
> +
> +       struct gpio_desc        *reset_gpiod;
> +       u32 rotation;
> +};
> +

Hi Paul, you put the mipi_dsi_device inside the struct. I think it maybe not
a good idea. That means the panel has a MIPI-DSI interface but it doesn't
have actually.

> +static int ili9341_probe(struct mipi_dsi_device *dsi)
> +{
> +       struct device *dev = &dsi->dev;
> +       struct ili9341 *priv;
> +       int ret;
> +
> +       /* See comment for mipi_dbi_spi_init() */
> +       if (!dev->coherent_dma_mask) {
> +               ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32));
> +               if (ret) {
> +                       dev_warn(dev, "Failed to set dma mask %d\n", ret);
> +                       return ret;
> +               }
> +       }
> +
> +       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> +       if (!priv)
> +               return -ENOMEM;
> +
> +       mipi_dsi_set_drvdata(dsi, priv);
> +       priv->dsi = dsi;
> +
> +       device_property_read_u32(dev, "rotation", &priv->rotation);
> +
> +       priv->pdata = device_get_match_data(dev);
> +       if (!priv->pdata)
> +               return -EINVAL;
> +
> +       drm_panel_init(&priv->panel, dev, &ili9341_funcs,
> +                      DRM_MODE_CONNECTOR_DPI);
> +
> +       priv->reset_gpiod = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> +       if (IS_ERR(priv->reset_gpiod)) {
> +               dev_err(dev, "Couldn't get our reset GPIO\n");
> +               return PTR_ERR(priv->reset_gpiod);
> +       }
> +
> +       ret = drm_panel_of_backlight(&priv->panel);
> +       if (ret < 0) {
> +               if (ret != -EPROBE_DEFER)
> +                       dev_err(dev, "Failed to get backlight handle\n");
> +               return ret;
> +       }
> +
> +       drm_panel_add(&priv->panel);
> +
> +       dsi->bus_type = priv->pdata->bus_type;
> +       dsi->lanes = priv->pdata->lanes;
> +       dsi->format = MIPI_DSI_FMT_RGB565;
> +
> +       ret = mipi_dsi_attach(dsi);
> +       if (ret) {
> +               dev_err(dev, "Failed to attach DSI panel\n");
> +               goto err_panel_remove;
> +       }
> +
> +       ret = mipi_dsi_maybe_register_tiny_driver(dsi);
> +       if (ret) {
> +               dev_err(dev, "Failed to init TinyDRM driver\n");
> +               goto err_mipi_dsi_detach;
> +       }
> +
> +       return 0;
> +
> +err_mipi_dsi_detach:
> +       mipi_dsi_detach(dsi);
> +err_panel_remove:
> +       drm_panel_remove(&priv->panel);
> +       return ret;
> +}
> +
> +static int ili9341_remove(struct mipi_dsi_device *dsi)
> +{
> +       struct ili9341 *priv = mipi_dsi_get_drvdata(dsi);
> +
> +       mipi_dsi_detach(dsi);
> +       drm_panel_remove(&priv->panel);
> +
> +       drm_panel_disable(&priv->panel);
> +       drm_panel_unprepare(&priv->panel);
> +
> +       return 0;
> +}
> +
> +static const struct ili9341_pdata yx240qv29_pdata = {
> +       .mode = { DRM_SIMPLE_MODE(240, 320, 37, 49) },
> +       .width_mm = 0, // TODO
> +       .height_mm = 0, // TODO
> +       .bus_type = MIPI_DCS_BUS_TYPE_DBI_SPI_C3,
> +       .lanes = 1,
> +};
> +
> +static const struct of_device_id ili9341_of_match[] = {
> +       { .compatible = "adafruit,yx240qv29", .data = &yx240qv29_pdata },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(of, ili9341_of_match);
> +
> +static struct mipi_dsi_driver ili9341_dsi_driver = {
> +       .probe          = ili9341_probe,
> +       .remove         = ili9341_remove,
> +       .driver = {
> +               .name           = "ili9341-dsi",
> +               .of_match_table = ili9341_of_match,
> +       },
> +};
> +module_mipi_dsi_driver(ili9341_dsi_driver);

Again, you treat this driver as a mipi dsi driver but for a MIPI-DBI (I8080/SPI)
panel device. That will make developers confused.

Is it possible to just add a mipi_dbi_driver for I8080/SPI interface panel?
Thanks!


Best regards

________________________________
 This email (including its attachments) is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Unauthorized use, dissemination, distribution or copying of this email or the information herein or taking any action in reliance on the contents of this email or the information herein, by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is strictly prohibited. If you are not the intended recipient, please do not read, copy, use or disclose any part of this e-mail to others. Please notify the sender immediately and permanently delete this e-mail and any attachments if you received it in error. Internet communications cannot be guaranteed to be timely, secure, error-free or virus-free. The sender does not accept liability for any errors or omissions.
本邮件及其附件具有保密性质，受法律保护不得泄露，仅发送给本邮件所指特定收件人。严禁非经授权使用、宣传、发布或复制本邮件或其内容。若非该特定收件人，请勿阅读、复制、 使用或披露本邮件的任何内容。若误收本邮件，请从系统中永久性删除本邮件及所有附件，并以回复邮件的方式即刻告知发件人。无法保证互联网通信及时、安全、无误或防毒。发件人对任何错漏均不承担责任。

Powered by blists - more mailing lists