linux-kernel - Re: [PATCH v2 2/2] pinctrl: mcp23s08: Fix mcp23x17 precious range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VenLVCARSJ9oTZRF4uuq9QHy4zrrVpwjEdXxMAHJNvzsQ@mail.gmail.com>
Date:   Sun, 30 Aug 2020 20:43:35 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Thomas Preston <thomas.preston@...ethink.co.uk>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jan Kundrát <jan.kundrat@...net.cz>,
        Phil Reid <preid@...ctromag.com.au>
Subject: Re: [PATCH v2 2/2] pinctrl: mcp23s08: Fix mcp23x17 precious range

On Sat, Aug 29, 2020 at 12:33 AM Thomas Preston
<thomas.preston@...ethink.co.uk> wrote:
>
> On page 23 of the datasheet [0] it says "The register remains unchanged
> until the interrupt is cleared via a read of INTCAP or GPIO." Include
> INTCAPA and INTCAPB registers in precious range, so that they aren't
> accidentally cleared when we read via debugfs.
>

> [0] https://ww1.microchip.com/downloads/en/DeviceDoc/20001952C.pdf

I would convert it to tag Datasheet: https://...

Maybe Linus can amend this when applying.

> Fixes: 8f38910ba4f6 ("pinctrl: mcp23s08: switch to regmap caching")
> Signed-off-by: Thomas Preston <thomas.preston@...ethink.co.uk>
> ---
>  drivers/pinctrl/pinctrl-mcp23s08.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
> index 87cde8fb08dd9..7edb067f5e76a 100644
> --- a/drivers/pinctrl/pinctrl-mcp23s08.c
> +++ b/drivers/pinctrl/pinctrl-mcp23s08.c
> @@ -109,7 +109,7 @@ static const struct regmap_access_table mcp23x17_volatile_table = {
>  };
>
>  static const struct regmap_range mcp23x17_precious_range = {
> -       .range_min = MCP_GPIO << 1,
> +       .range_min = MCP_INTCAP << 1,
>         .range_max = MCP_GPIO << 1,
>  };
>
> --
> 2.26.2
>


-- 
With Best Regards,
Andy Shevchenko