linux-kernel - Re: [PATCH] USB: integrate macro definitions into include/linux/usb.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97eb35be-9550-ea50-da72-5ce10757379b@windriver.com>
Date:   Sun, 30 Aug 2020 13:23:24 +0800
From:   "Xu, Yanfei" <yanfei.xu@...driver.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: integrate macro definitions into include/linux/usb.h

I just think it is a clear up to make these macros get togather
which have the samilar attributes. That's why :)

Thanks,
Yanfei

On 8/28/20 3:48 PM, Greg KH wrote:
> On Tue, Aug 25, 2020 at 11:44:21PM +0800, yanfei.xu@...driver.com wrote:
>> From: Yanfei Xu <yanfei.xu@...driver.com>
>>
>> include/linux/usb.h also contains 'Hard limit' and 'Arbitrary limit'
>> macro definitions in it, hence we can integrate these from config.c
>> into include/linux/usb.h
> 
> Why?  No one uses these values outside of this .c file, so why put a
> value in a global .h file?
> 
> Who else wants to use these values?  If something else needs it, then
> sure, it could be moved, but until then, there's nothing wrong with the
> existing code as-is from what I can tell.
> 
> thanks,
> 
> greg k-h
>