linux-kernel - Re: [PATCH] selftests: use "$(MAKE)" instead of "make" for headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ea61655-c4b3-0fa9-ec70-b63adbbe5c84@linuxfoundation.org>
Date:   Mon, 31 Aug 2020 14:49:50 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Denys Vlasenko <dvlasenk@...hat.com>, linux-kernel@...r.kernel.org
Cc:     Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: use "$(MAKE)" instead of "make" for
 headers_install

On 8/17/20 9:09 AM, Denys Vlasenko wrote:
> If top make invocation uses -j4 or larger, this patch reduces
> "make headers_install" subtask run time from 30 to 7 seconds.
> 
> CC: Shuah Khan <shuah@...nel.org>
> CC: Shuah Khan <skhan@...uxfoundation.org>
> CC: linux-kselftest@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> ---
>   tools/testing/selftests/lib.mk | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 7a17ea815736..51124b962d56 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -47,9 +47,9 @@ ARCH		?= $(SUBARCH)
>   khdr:
>   ifndef KSFT_KHDR_INSTALL_DONE
>   ifeq (1,$(DEFAULT_INSTALL_HDR_PATH))
> -	make --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install
> +	$(MAKE) --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install
>   else
> -	make --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \
> +	$(MAKE) --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \
>   		ARCH=$(ARCH) -C $(top_srcdir) headers_install
>   endif
>   endif
> 

Thanks for the patch. Applied to linux-kselftest next for 5.10

thanks,
-- Shuah