| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Aug 2020 23:31:30 +0200
From: Alexander Dahl <post@...pocky.de>
To: linux-leds@...r.kernel.org, devicetree@...r.kernel.org
Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>,
Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
Alexander Dahl <ada@...rsis.com>,
Alexander Dahl <post@...pocky.de>
Subject: Re: [PATCH v2 2/2] dt-bindings: leds: Convert pwm to yaml
Hei hei,
I forgot to run checkpatch (it's late today already), and it warns:
WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)
#80: FILE: Documentation/devicetree/bindings/leds/leds-pwm.yaml:1:
+# SPDX-License-Identifier: GPL-2.0-only
tbh, I just copied that line from leds-gpio.yaml, can be changed in a
v3 of course.
Greets
Alex
On Mon, Aug 31, 2020 at 11:02:31PM +0200, Alexander Dahl wrote:
> The example was adapted slightly to make use of the 'function' and
> 'color' properties.
>
> Suggested-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Signed-off-by: Alexander Dahl <post@...pocky.de>
> ---
> .../devicetree/bindings/leds/leds-pwm.txt | 50 -----------
> .../devicetree/bindings/leds/leds-pwm.yaml | 85 +++++++++++++++++++
> 2 files changed, 85 insertions(+), 50 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
> create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt
> deleted file mode 100644
> index 6c6583c35f2f..000000000000
> --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -LED connected to PWM
> -
> -Required properties:
> -- compatible : should be "pwm-leds".
> -
> -Each LED is represented as a sub-node of the pwm-leds device. Each
> -node's name represents the name of the corresponding LED.
> -
> -LED sub-node properties:
> -- pwms : PWM property to point to the PWM device (phandle)/port (id) and to
> - specify the period time to be used: <&phandle id period_ns>;
> -- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device
> - For the pwms and pwm-names property please refer to:
> - Documentation/devicetree/bindings/pwm/pwm.txt
> -- max-brightness : Maximum brightness possible for the LED
> -- active-low : (optional) For PWMs where the LED is wired to supply
> - rather than ground.
> -- label : (optional)
> - see Documentation/devicetree/bindings/leds/common.txt
> -- linux,default-trigger : (optional)
> - see Documentation/devicetree/bindings/leds/common.txt
> -
> -Example:
> -
> -twl_pwm: pwm {
> - /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
> - compatible = "ti,twl6030-pwm";
> - #pwm-cells = <2>;
> -};
> -
> -twl_pwmled: pwmled {
> - /* provides one PWM (id 0 for Charing indicator LED) */
> - compatible = "ti,twl6030-pwmled";
> - #pwm-cells = <2>;
> -};
> -
> -pwmleds {
> - compatible = "pwm-leds";
> - kpad {
> - label = "omap4::keypad";
> - pwms = <&twl_pwm 0 7812500>;
> - max-brightness = <127>;
> - };
> -
> - charging {
> - label = "omap4:green:chrg";
> - pwms = <&twl_pwmled 0 7812500>;
> - max-brightness = <255>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> new file mode 100644
> index 000000000000..8c5217f2a9f7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> @@ -0,0 +1,85 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LEDs connected to PWM
> +
> +maintainers:
> + - Pavel Machek <pavel@....cz>
> +
> +description:
> + Each LED is represented as a sub-node of the pwm-leds device. Each
> + node's name represents the name of the corresponding LED.
> +
> +properties:
> + compatible:
> + const: pwm-leds
> +
> +patternProperties:
> + "^pwm-led-([0-9a-f])$":
> + type: object
> +
> + $ref: common.yaml#
> +
> + properties:
> + pwms:
> + description:
> + "PWM property to point to the PWM device (phandle)/port (id)
> + and to specify the period time to be used:
> + <&phandle id period_ns>;"
> +
> + pwm-names:
> + description:
> + "Name to be used by the PWM subsystem for the PWM device For
> + the pwms and pwm-names property please refer to:
> + Documentation/devicetree/bindings/pwm/pwm.txt"
> +
> + max-brightness:
> + description:
> + Maximum brightness possible for the LED
> +
> + active-low:
> + description:
> + For PWMs where the LED is wired to supply rather than ground.
> +
> + required:
> + - pwms
> + - max-brightness
> +
> +examples:
> + - |
> +
> + #include <dt-bindings/leds/common.h>
> +
> + twl_pwm: pwm {
> + /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
> + compatible = "ti,twl6030-pwm";
> + #pwm-cells = <2>;
> + };
> +
> + twl_pwmled: pwmled {
> + /* provides one PWM (id 0 for Charing indicator LED) */
> + compatible = "ti,twl6030-pwmled";
> + #pwm-cells = <2>;
> + };
> +
> + pwm_leds {
> + compatible = "pwm-leds";
> +
> + pwm-led-1 {
> + label = "omap4::keypad";
> + pwms = <&twl_pwm 0 7812500>;
> + max-brightness = <127>;
> + };
> +
> + pwm-led-2 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_CHARGING;
> + pwms = <&twl_pwmled 0 7812500>;
> + max-brightness = <255>;
> + };
> + };
> +
> +...
> --
> 2.20.1
--
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN | speech censured, the first thought forbidden, the
X AGAINST | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists