linux-kernel - Re: [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMGffE=RQiPxjA+vxVfj_zCBfJy6PiOdJpkTWC+DRDzDW_nDZg@mail.gmail.com>
Date:   Mon, 31 Aug 2020 08:15:31 +0200
From:   Jinpu Wang <jinpu.wang@...ud.ionos.com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort

On Sun, Aug 23, 2020 at 11:15 AM Dinghao Liu <dinghao.liu@....edu.cn> wrote:
>
> When pm8001_tag_alloc() fails, task should be freed just
> like what we've done in the subsequent error paths.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
Thanks!
Acked-by: Jack Wang <jinpu.wang@...ud.ionos.com>
> ---
>  drivers/scsi/pm8001/pm8001_sas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index 337e79d6837f..9889bab7d31c 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -818,7 +818,7 @@ pm8001_exec_internal_task_abort(struct pm8001_hba_info *pm8001_ha,
>
>                 res = pm8001_tag_alloc(pm8001_ha, &ccb_tag);
>                 if (res)
> -                       return res;
> +                       goto ex_err;
>                 ccb = &pm8001_ha->ccb_info[ccb_tag];
>                 ccb->device = pm8001_dev;
>                 ccb->ccb_tag = ccb_tag;
> --
> 2.17.1
>