linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: prevent compressed file from being disabled after releasing cblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Aug 2020 15:15:52 +0900
From:   Daeho Jeong <daeho43@...il.com>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     Chao Yu <chao@...nel.org>, Daeho Jeong <daehojeong@...gle.com>,
        kernel-team@...roid.com, linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: prevent compressed file from being
 disabled after releasing cblocks

I think this patch is enough for now.
If you have anything else we should take care, please let me know~

2020년 8월 31일 (월) 오후 3:08, Chao Yu <yuchao0@...wei.com>님이 작성:
>
> On 2020/8/31 11:55, Daeho Jeong wrote:
> >> - open(O_RDWR)
> >> - ioctl(FS_IOC_SETFLAGS, F2FS_COMPR_FL)
> >> - write()
> >> - ioctl(RELEASE_COMPRESS_BLOCKS) -- inode is immutable now
> >> - ioctl(FS_IOC_SETFLAGS, ~F2FS_COMPR_FL) -- Should we allow to update immutable inode?
> >> as we know, normally, immutable inode should deny open(O_WRONLY or O_RDWR) and later update.
> >>
> >
> > For this case, with this patch we'll return -EINVAL for
> > ioctl(FS_IOC_SETFLAGS, ~F2FS_COMPR_FL).
> > I thought RESERVE_COMPRESS_BLOCKS ioctl is always required to get the
> > file to normal mode after RELEASE_COMPRESS_BLOCKS is called.
>
> That's an example, after compressed block release, shouldn't we disallow other ioctl
> interface which updates immutable inode?
>
> > .
> >