linux-kernel - Re: [GIT pull] x86/urgent for v5.9-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mu2bi900.fsf@nanos.tec.linutronix.de>
Date:   Mon, 31 Aug 2020 09:12:47 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [GIT pull] x86/urgent for v5.9-rc2

On Sun, Aug 30 2020 at 12:13, Linus Torvalds wrote:
> On Sun, Aug 30, 2020 at 11:04 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>>
>>    The historical inconsistent for_each_cpu() behaviour of
>>    ignoring the cpumask and unconditionally claiming that CPU0 is in the
>>    mask struck again. Sigh.
>
> I guess we could remove the UP optimizations these days. It's not like
> they matter like they used to.

Indeed.

> Or leave the optimizations in the sense that they wouldn't do the
> crazy bit searching, but they could look at bit 0 of the mask they're
> passed..

Yes, that's trivial enough and the compiler should turn the whole thing
into a simple conditional checking bit 0 and remove the rest of the loop
gunk.

Thanks,

        tglx