linux-kernel - Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4169cc5-643b-67f1-5b19-c3265a341a8f@arm.com>
Date:   Mon, 31 Aug 2020 13:43:55 +0530
From:   Amit Kachhap <amit.kachhap@....com>
To:     Boyan Karatotev <boyan.karatotev@....com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     vincenzo.frascino@....com, boian4o1@...il.com,
        Shuah Khan <shuah@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>
Subject: Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec()
 changes keys



On 8/28/20 6:46 PM, Boyan Karatotev wrote:
> Kernel documentation states that it will change PAuth keys on exec() calls.
> 
> Verify that all keys are correctly switched to new ones.
> 
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Signed-off-by: Boyan Karatotev <boyan.karatotev@....com>

The changes look fine so,
Reviewed-by: Amit Daniel Kachhap <amit.kachhap@....com>

> ---
>   tools/testing/selftests/arm64/pauth/Makefile  |   4 +
>   .../selftests/arm64/pauth/exec_target.c       |  35 +++++
>   tools/testing/selftests/arm64/pauth/helper.h  |  10 ++
>   tools/testing/selftests/arm64/pauth/pac.c     | 148 ++++++++++++++++++
>   4 files changed, 197 insertions(+)
>   create mode 100644 tools/testing/selftests/arm64/pauth/exec_target.c
> 
> diff --git a/tools/testing/selftests/arm64/pauth/Makefile b/tools/testing/selftests/arm64/pauth/Makefile
> index a017d1c8dd58..2e237b21ccf6 100644
> --- a/tools/testing/selftests/arm64/pauth/Makefile
> +++ b/tools/testing/selftests/arm64/pauth/Makefile
> @@ -5,6 +5,7 @@ CFLAGS += -mbranch-protection=pac-ret
>