linux-kernel - Re: [PATCH v2 9/9] perf: Remove x86 specific rdpmc test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200831091113.GA406859@krava>
Date:   Mon, 31 Aug 2020 11:11:13 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Raphael Gault <raphael.gault@....com>,
        Mark Rutland <mark.rutland@....com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Ian Rogers <irogers@...gle.com>, honnappa.nagarahalli@....com
Subject: Re: [PATCH v2 9/9] perf: Remove x86 specific rdpmc test

On Fri, Aug 28, 2020 at 02:56:14PM -0600, Rob Herring wrote:
> Now that we have a common libperf based userspace counter read test
> with the same functionality as the x86 specific rdpmc test, let's remove
> it.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> This one is optional. On the plus side, it eliminates a copy of the read
> loop. The main downside I see is loosing the ability to test in 'perf test'.
> 
> 
>  tools/perf/arch/x86/include/arch-tests.h |   1 -
>  tools/perf/arch/x86/tests/Build          |   1 -
>  tools/perf/arch/x86/tests/arch-tests.c   |   4 -
>  tools/perf/arch/x86/tests/rdpmc.c        | 182 -----------------------
>  4 files changed, 188 deletions(-)
>  delete mode 100644 tools/perf/arch/x86/tests/rdpmc.c
> 
> diff --git a/tools/perf/arch/x86/include/arch-tests.h b/tools/perf/arch/x86/include/arch-tests.h
> index c41c5affe4be..d9c32ba0cdac 100644
> --- a/tools/perf/arch/x86/include/arch-tests.h
> +++ b/tools/perf/arch/x86/include/arch-tests.h
> @@ -6,7 +6,6 @@
>  struct test;
> 
>  /* Tests */
> -int test__rdpmc(struct test *test __maybe_unused, int subtest);

we don't currently run libperf tests as part of perf test suite,
so before we do that, I rather not remove the tests..

feel free to add the code that runs libperf tests within 'perf test'
command ;-)

thanks,
jirka