linux-kernel - Re: [PATCH] leds: pwm: Allow automatic labels for DT based devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1837645.vzTIdMnA0P@ada>
Date:   Mon, 31 Aug 2020 11:20:09 +0200
From:   Alexander Dahl <ada@...rsis.com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     linux-leds@...r.kernel.org, Pavel Machek <pavel@....cz>,
        Dan Murphy <dmurphy@...com>, linux-kernel@...r.kernel.org,
        Alexander Dahl <post@...pocky.de>
Subject: Re: [PATCH] leds: pwm: Allow automatic labels for DT based devices

Hello Jacek,

Am Freitag, 28. August 2020, 22:43:02 CEST schrieb Jacek Anaszewski:
> On 8/28/20 9:00 AM, Alexander Dahl wrote:
> > Am Donnerstag, 27. August 2020, 23:28:45 CEST schrieb Jacek Anaszewski:
> >> This part looks good, but corresponding update of
> >> Documentation/devicetree/bindings/leds/leds-pwm.txt is needed as well.
> > 
> > I'm not sure, what needs updating. The properties 'function' and 'color'
> > are already documented in
> > Documentation/devicetree/bindings/leds/common.yaml … the only thing I can
> > think of here is updating the examples? That would be nice, as would be
> > updating to yaml, but I don't see the strong relation, yet.
> It is necessary to tell the user that given driver is capable of
> utilizing a property. I thought of something like in commit [0].
> 
> >> It would be good to switch to yaml by this occassion.
> > 
> > Is there some guidance on that in general?
> 
> I am not aware of, but surely sooner or later all bindings will
> need to be unified. Touching the file is always a good opportunity
> to address that. It's up to you, though.

This update from txt to yaml is a manual task and after reading [1] and some 
other examples, I tried to come up with something.  I pushed the WIP to my 
GitHub tree and will run the checks recommended by [1] later in the evening.  
If that goes well, I'll send a v2 series.

> [0]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Do
> cumentation/devicetree/bindings/leds/leds-lm3692x.txt?id=4dcbc8f8c59f4b618d6
> 51f5ba884ee5bf562c8de

Well okay, that was for the old format, but I see what you mean.

Greets
Alex

[1] https://www.kernel.org/doc/html/latest/devicetree/writing-schema.html