[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAM9Jb+hBeZO=y0=pKUhT6G=qF8-mcZU86wY_A6N7-cT5tJ1wmw@mail.gmail.com>
Date: Mon, 31 Aug 2020 11:45:20 +0200
From: Pankaj Gupta <pankaj.gupta.linux@...il.com>
To: Muchun Song <songmuchun@...edance.com>
Cc: naoya.horiguchi@....com, Andrew Morton <akpm@...ux-foundation.org>,
Linux MM <linux-mm@...ck.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/memory-failure: Fix return wrong value when isolate
page fail
> When we isolate page fail, we should not return 0, because we do not
> set page HWPoison on any page.
>
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> ---
> mm/memory-failure.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 696505f56910..4eb3c42ffe35 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1850,6 +1850,7 @@ static int __soft_offline_page(struct page *page)
> } else {
> pr_info("soft offline: %#lx: %s isolation failed: %d, page count %d, type %lx (%pGp)\n",
> pfn, msg_page[huge], ret, page_count(page), page->flags, &page->flags);
> + ret = -EBUSY;
> }
> return ret;
> }
> --
Acked-by: Pankaj Gupta <pankaj.gupta.linux@...il.com>
> 2.11.0
>
>
Powered by blists - more mailing lists