linux-kernel - Re: [PATCH] ALSA: opti9xx: Fix memleak in snd_opti9xx_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5ho8mri1sh.wl-tiwai@suse.de>
Date:   Mon, 31 Aug 2020 11:48:30 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: opti9xx: Fix memleak in snd_opti9xx_read_check

On Sat, 29 Aug 2020 10:05:15 +0200,
Dinghao Liu wrote:
> 
> When request_region() on chip->res_mc_indir fails,
> chip->res_mc_base should be freed to prevent memleak.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

The resources are freed automatically at private_free callback
(snd_card_opti9xx_free()) called via snd_card_free() in the error
path, hence this patch would lead to double-free.


thanks,

Takashi


> ---
>  sound/isa/opti9xx/opti92x-ad1848.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
> index 881d3b5711d2..06ba18d1737c 100644
> --- a/sound/isa/opti9xx/opti92x-ad1848.c
> +++ b/sound/isa/opti9xx/opti92x-ad1848.c
> @@ -679,8 +679,11 @@ static int snd_opti9xx_read_check(struct snd_opti9xx *chip)
>  #else	/* OPTi93X */
>  	chip->res_mc_indir = request_region(chip->mc_indir_index, 2,
>  					    "OPTi93x MC");
> -	if (chip->res_mc_indir == NULL)
> +	if (chip->res_mc_indir == NULL) {
> +		release_and_free_resource(chip->res_mc_base);
> +		chip->res_mc_base = NULL;
>  		return -EBUSY;
> +	}
>  
>  	spin_lock_irqsave(&chip->lock, flags);
>  	outb(chip->password, chip->mc_base + chip->pwd_reg);
> -- 
> 2.17.1
>