linux-kernel - Re: [PATCH] dma-buf: fix kernel-doc warning in <linux/dma-buf.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b97f98ed-75b7-400c-07d3-89f49c5bb809@amd.com>
Date:   Mon, 31 Aug 2020 12:00:04 +0200
From:   Christian König <christian.koenig@....com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Sumit Semwal <sumit.semwal@...aro.org>,
        Gustavo Padovan <gustavo@...ovan.org>,
        linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] dma-buf: fix kernel-doc warning in <linux/dma-buf.h>

Am 31.08.20 um 06:16 schrieb Randy Dunlap:
> Fix kernel-doc warning in <linux/dma-buf.h>:
>
> ../include/linux/dma-buf.h:330: warning: Function parameter or member 'name_lock' not described in 'dma_buf'
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Cc: Gustavo Padovan <gustavo@...ovan.org>
> Cc: Christian König <christian.koenig@....com>
> Cc: linux-media@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   include/linux/dma-buf.h |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- lnx-59-rc3.orig/include/linux/dma-buf.h
> +++ lnx-59-rc3/include/linux/dma-buf.h
> @@ -283,6 +283,7 @@ struct dma_buf_ops {
>    * @exp_name: name of the exporter; useful for debugging.
>    * @name: userspace-provided name; useful for accounting and debugging,
>    *        protected by @resv.
> + * @name_lock: spinlock to protect name access
>    * @owner: pointer to exporter module; used for refcounting when exporter is a
>    *         kernel module.
>    * @list_node: node for dma_buf accounting and debugging.
> @@ -311,7 +312,7 @@ struct dma_buf {
>   	void *vmap_ptr;
>   	const char *exp_name;
>   	const char *name;
> -	spinlock_t name_lock; /* spinlock to protect name access */
> +	spinlock_t name_lock;
>   	struct module *owner;
>   	struct list_head list_node;
>   	void *priv;